JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
610 stars 251 forks source link

Fix pluralization when printing 2-1024 bytes #3799

Closed christiangnrd closed 2 months ago

christiangnrd commented 4 months ago

Alternative to #3763 that doesn't include any new private Base functions.

I prefer #3763, but this version might be easier to merge.

Closes #3763.

christiangnrd commented 3 months ago

Bump. I've made a sample output to show what this changes.

Before:

Deleted `0byte.txt` (0.000 byte)
Deleted `1byte.txt` (1.000 byte)
Deleted `2bytes.txt` (2.000 byte)
Deleted `1023bytes.txt` (1023.000 byte)
Deleted `1024bytes.txt` (1024.000 byte)
Deleted `1025bytes.txt` (1.001 KiB)
Deleted 1 package (0.000 byte)
Deleted 1 package (1.000 byte)
Deleted 1 package (2.000 byte)
Deleted 1 package (1023.000 byte)
Deleted 1 package (1024.000 byte)
Deleted 1 package (1.001 KiB)

After:

Deleted `0byte.txt` (0.000 bytes)
Deleted `1byte.txt` (1.000 byte)
Deleted `2bytes.txt` (2.000 bytes)
Deleted `1023bytes.txt` (1023.000 bytes)
Deleted `1024bytes.txt` (1024.000 bytes)
Deleted `1025bytes.txt` (1.001 KiB)
Deleted 1 package (0.000 bytes)
Deleted 1 package (1.000 byte)
Deleted 1 package (2.000 bytes)
Deleted 1 package (1023.000 bytes)
Deleted 1 package (1024.000 bytes)
Deleted 1 package (1.001 KiB)