search

JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
610 stars 251 forks source link

Prevent repl crash on invalid command #3800

Closed oscardssmith closed 4 months ago

oscardssmith commented 4 months ago

Previously, prepare_cmd was outside the lock. fixes https://github.com/JuliaLang/Pkg.jl/issues/3787

oscardssmith commented 4 months ago

This needs tests, but I'm not entirely sure where the test should go.

KristofferC commented 4 months ago

Testing this is a bit awkward since it would require firing up and simulating a REPL and I don't think we should block that on getting this fixed.