JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
610 stars 251 forks source link

avoid registry warning during precompile #3811

Closed IanButterworth closed 4 months ago

IanButterworth commented 4 months ago

Avoids

    JULIA stdlib/REPLExt.release.image
    JULIA stdlib/LazyArtifacts.release.image
    JULIA stdlib/LazyArtifacts.release.image
 │ Attempted to find missing packages in package registries but no registries are installed.
 └ Use package mode to install a registry. `pkg> registry add` will install the default registries.

    JULIA stdlib/REPLExt.release.image
 │ Attempted to find missing packages in package registries but no registries are installed.
 └ Use package mode to install a registry. `pkg> registry add` will install the default registries.

Pkg.jl precompile.jl does this, which is why it didn't show before, I believe.

I guess it means the registry stuff isn't baked in properly.. but that would need a better fix i.e. https://github.com/JuliaLang/Pkg.jl/pull/2833

KristofferC commented 4 months ago

I guess it means the registry stuff isn't baked in properly.

What does this mean?

IanButterworth commented 4 months ago

Actually this isn't enough.. I checked with a julia build and still see the messages.

I guess it means the registry stuff isn't baked in properly. What does this mean?

I mean that if the Pkg precompile process is being told not to update the registry, then the registry update code paths aren't being hit during precompilation

IanButterworth commented 4 months ago

This looks clean in a julia build now

    JULIA stdlib/Pkg.release.image
    JULIA stdlib/Pkg.release.image
    JULIA stdlib/REPLExt.release.image
    JULIA stdlib/LazyArtifacts.release.image
    JULIA stdlib/LazyArtifacts.release.image
    JULIA stdlib/REPLExt.release.image
ian@Ians-MBP julia %
IanButterworth commented 4 months ago

@KristofferC this look ok to you?

KristofferC commented 4 months ago

👍