search

JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
609 stars 251 forks source link

Precompile the pkg tab completion hint #3910

Closed IanButterworth closed 4 weeks ago

IanButterworth commented 1 month ago

Minor precompiles but should help snappiness Based on https://github.com/JuliaLang/julia/pull/54594

KristofferC commented 4 weeks ago

Did you measure the results in any way?

IanButterworth commented 4 weeks ago

On that julia PR this reduces the methods needing to be precompiled in the switch by 1.

I haven't measured timing improvement.

Is there a reason to motivate this further?

IanButterworth commented 4 weeks ago

Using https://github.com/JuliaLang/julia/pull/54662 this saves 234ms off the first tab completion hint

precompile(Tuple{typeof(Core.kwcall), NamedTuple{(:hint,), Tuple{Bool}}, typeof(REPL.LineEdit.complete_line), REPLExt.PkgCompletionProvider, REPL.LineEdit.PromptState}) # 235.111000ms