avoid returning empty completion when aborting to not have it inline directories

JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language

https://pkgdocs.julialang.org

Other

609 stars 251 forks source link

avoid returning empty completion when aborting to not have it inline directories #3917

Closed KristofferC closed 2 weeks ago

KristofferC commented 4 weeks ago

Should fix #3916 (haven't tested)

kimikage commented 3 weeks ago

I believe I still lack the composure to review this PR.

As a matter of fact, my REPL did not hint "Documents/" when "Doc" was typed, and hinted "DocumenterTools" when "DocumenterT" was typed. pkg_3917

kimikage commented 1 week ago

This is definitely an improvement, but I realized that this is not a perfect solution after looking at https://github.com/JuliaLang/julia/issues/54906 (unrelated to this PR).

If you type "add Cha", "ChainRules" and "ChainRulesCore" will be candidates, and "ChainRules" will be displayed as a hint. Given the existence of "Chairmarks", the hint is somewhat misleading.

KristofferC commented 1 week ago

I didn't know that the inline auto complete did partial completions like that. I even thought I tried it...