search

JuliaLang / Pkg.jl

Pkg - Package manager for the Julia programming language
https://pkgdocs.julialang.org
Other
609 stars 251 forks source link

Fix HistoricalStdlibVersions install to version #3930

Closed IanButterworth closed 2 weeks ago

IanButterworth commented 2 weeks ago

Fixes https://github.com/JuliaLang/Pkg.jl/issues/3929

Given this branch isn't touched on this CI

% julia  
               _
   _       _ _(_)_     |  Documentation: https://docs.julialang.org
  (_)     | (_) (_)    |
   _ _   _| |_  __ _   |  Type "?" for help, "]?" for Pkg help.
  | | | | | | |/ _` |  |
  | | |_| | | | (_| |  |  Version 1.10.4 (2024-06-04)
 _/ |\__'_|_|_|\__'_|  |  Official https://julialang.org/ release
|__/                   |

(@v1.10) pkg> activate --temp
  Activating new project at `/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55`

julia> import Pkg

julia> Pkg.add(name="HistoricalStdlibVersions", version="1.2")
   Resolving package versions...
    Updating `/private/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55/Project.toml`
⌃ [6df8b67a] + HistoricalStdlibVersions v1.2.4
    Updating `/private/var/folders/1z/jf841bdj73bdj3vk7kc7f_3w0000gn/T/jl_0iHV55/Manifest.toml`
⌃ [6df8b67a] + HistoricalStdlibVersions v1.2.4
        Info Packages marked with ⌃ have new versions available and may be upgradable.

julia> 
julia> Pkg.add(name="HistoricalStdlibVersions", version="1.2", io=iob)

julia>
DilumAluthge commented 2 weeks ago

@IanButterworth The backport label for 1.10 has no hyphen, but the backport label for 1.11 does have a hyphen. Is that something we need to fix? Does this break the Backporter script?

IanButterworth commented 2 weeks ago

Good catch https://github.com/KristofferC/Backporter/blob/f366a87a94c9d38fd107a1c53ccc4550f3687625/backporter.jl#L23

Fixed