search

JuliaLang / julia

The Julia Programming Language
https://julialang.org/
MIT License
45.91k stars 5.49k forks source link

Source code for julia/contrib/windows/7zS.sfx missing #30475

Closed cdluminate closed 5 years ago

cdluminate commented 5 years ago

I'm afraid there isn't source code for 7zS.sfx in julia's source tarball. Missing source code violates Debian's free software guideline, and we (Debian) will remove 7zS.sfx from the source tarball being distributed by Debian itself[1].

Is source code for 7zS.sfx available?

Sorry if I opened a stupid issue, but I'm really not familiar with any windows-related file. [1] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916957

musm commented 5 years ago

Seems to be fixed according to the last message in the linked thread https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=916957 ?

vtjnash commented 5 years ago

Only in their out-of-tree fork. Note that the source for this file is contained in the original commit message: 21e12c49935dd1863a966c1cdb0b1371cc1a3789.

musm commented 5 years ago

someone should reopen this issue since it's not fixed

vtjnash commented 5 years ago

Or just merge https://github.com/JuliaLang/julia/pull/33302?

musm commented 5 years ago

Right, my only concern with that PR is that NSIS doesn't use lzma2 so the compression and decompression speeds area bit worse. My laptop is very old so I can notice the difference, but perhaps it doesn't matter that much or we dont' care?

musm commented 5 years ago

Although I do think the current method is pretty round-about and it would be very nice to simplify the build process by merging #33302

musm commented 5 years ago

Ideally we should just switch to inno setup, it's far more robust and easier and more modern.

They only question is how to run it in the makefile, I think can only be run on windows?

staticfloat commented 5 years ago

As noted on Slack, our windows buildbots are actually running windows, so that's no problem.