Use of `abs` in the pivoting branch of the generic lufact.

JuliaLang / julia

The Julia Programming Language

https://julialang.org/

MIT License

45.35k stars 5.46k forks source link

Use of `abs` in the pivoting branch of the generic lufact. #34574

Open mschauer opened 4 years ago

mschauer commented 4 years ago

The use of abs in the pivoting part broke some code of mine which was using the generic lu-fact on a matrix with elements of type SArray{Tuple{2,2},Float64,2,4}. This became visible with the change #32989 making pivoting the default. Would norm be an option there?

andreasnoack commented 4 years ago

Would norm be an option there?

I'd think so.

andreasnoack commented 4 years ago

Closed by #34575

mschauer commented 3 years ago

This should be open again, as #34575 wasn't the solution.