JuliaLang / julia

The Julia Programming Language
https://julialang.org/
MIT License
45.71k stars 5.48k forks source link

profiling: include interpreter frames #43796

Open vilterp opened 2 years ago

vilterp commented 2 years ago

Background

There are two types of stack frames: instruction pointers (to either C code or generated Julia code) and interpreter frames (Julia code being interpreted at runtime).

Problem

Interpreter frames only show up as unknown in CPU and allocation profiles.

Underlying issue

The backtrace buffers used by the CPU and Alloc profilers aren't GC roots, so the objects they point to (interpreter frames) can get garbage collected before a profiler user deferences them while decoding the profile. If you're not careful, this segfaults the process.

The CPU and alloc profiler currently sidestep this problem by using the StackTraces.lookup function to decode stack frames from raw backtrace buffers, which falls back on returning this "unknown" frame when it sees an interpreter frame: https://github.com/JuliaLang/julia/blob/00646634c6a73998eaae3785eb78fea881c39502/base/stacktraces.jl#L109

These don't seem to occur to frequently in practice, so we've gotten by without truly solving this problem.

Possible fix

In another memory profiling PR (https://github.com/JuliaLang/julia/pull/33467), @maleadt solved this problem by modifying the garbage collector's mark phase to find these pointers in backtrace buffers, thereby preventing them from being collected. Perhaps that change can be merged separately, so then both the allocation and CPU profilers can use reformat_bt, and include interpreter frames.

NHDaly commented 2 years ago

For more information, I think these interpreter frames currently show up as unknown in the profiles collected via the Profile package. This issue is about teaching the Profiler to understand the interpreter frames in the stack traces it samples, so that it can report the frames being interpreted, instead of unknown. 👍

vilterp commented 2 years ago

Thanks; edited a bit.