search

JuliaLang / julia

The Julia Programming Language
https://julialang.org/
MIT License
45.91k stars 5.49k forks source link

Documentation search result regression #52977

Open LilithHafner opened 10 months ago

LilithHafner commented 10 months ago

In 1.10, the search "threading" lists https://docs.julialang.org/en/v1.10/base/multi-threading/ first while in 1.11, it lists https://docs.julialang.org/en/v1.11-dev/NEWS/#Multi-threading-changes, https://docs.julialang.org/en/v1.11-dev/devdocs/locks/#Proper-maintenance-and-care-of-multi-threading-locks, and then https://docs.julialang.org/en/v1.11-dev/devdocs/locks/

It seems pretty clear to me that a manual page with an exact keyword match in it's title should rank first while it currently ranks 5th. I think this is a case-sensitivity bug upstream: https://github.com/JuliaDocs/Documenter.jl/issues/2373

1.10: Screenshot from 2024-01-19 09-24-41

master: Screenshot from 2024-01-19 09-25-01

@Hetarth02 changed the Documenter.jl search engine from LunrJs to MinisearchJs in https://github.com/JuliaDocs/Documenter.jl/pull/2172. According to https://hetarth02.hashnode.dev/crafting-an-enhanced-search-experience this seems like a good change overall.

We down streamed those changes into the Julia repo in https://github.com/JuliaLang/julia/pull/47105

Hetarth02 commented 10 months ago

Yes, I also think this might be a case sensitivity issue and there are PRs in work to fix this. I hope to close them as soon as possible.

PR #2374

PR #2375