Open George9000 opened 2 months ago
@Keno Does https://github.com/JuliaLang/julia/pull/54856 fix this issue?
No, but I have pending PRs to Revise and dependencies that fix this. The issue was pre-existing, the lowering change just happened to trigger it.
Fixed on master by this commit by Keno and Tim Holy on Revise. Grateful!
Revise is still broken. We're looking into it
On master, from commit 1cd47c3094 onward, the Revise workflow is broken. After launching julia, activating a package,
using packagename
, calling an existing function, and then adding a simple functionfoo
to the src/packagename.jl results in an error with failure to revise/update the running package code.The function foo is just
This addition to the package code results in an error. The error arises in JuliaInterpreter and its
utils.jl
A git bisect identifies 1cd47c3094 as the culprit.
error details
``` Julia Version 1.12.0-DEV.716 Commit 1cd47c3094 (2024-06-12 21:45 UTC) Platform Info: OS: macOS (arm64-apple-darwin23.5.0) CPU: 16 × Apple M3 Max WORD_SIZE: 64 LLVM: libLLVM-17.0.6 (ORCJIT, apple-m3) Threads: 1 default, 0 interactive, 1 GC (on 12 virtual cores) Environment: JULIA_EDITOR = Emacs JULIA_PKG_DEVDIR = /Users/bozo/Documents/julia/dev julia> foo() ┌ Error: Failed to revise /Volumes/work/julia/learnjulia/euler/src/euler.jl │ exception = │ BoundsError: attempt to access 0-element Vector{Base.IRShow.LineInfoNode} at index [1] │ Stacktrace: │ [1] throw_boundserror(A::Vector{Base.IRShow.LineInfoNode}, I::Tuple{Int64}) │ @ Base ./essentials.jl:14 │ [2] getindex │ @ ./essentials.jl:894 [inlined] │ [3] #linetable#7 │ @ ~/.julia/packages/JuliaInterpreter/tD6at/src/utils.jl:285 [inlined] │ [4] linetable │ @ ~/.julia/packages/JuliaInterpreter/tD6at/src/utils.jl:280 [inlined] │ [5] whereis(framecode::JuliaInterpreter.FrameCode, pc::Int64; kwargs::@Kwargs{}) │ @ JuliaInterpreter ~/.julia/packages/JuliaInterpreter/tD6at/src/utils.jl:389 └ @ Revise ~/.julia/packages/Revise/QSDHW/src/packagedef.jl:724 ┌ Warning: The running code does not match the saved version for the following files: │ │ /Volumes/work/julia/learnjulia/euler/src/euler.jl ```git bisect
``` % git bisect bad 0:23 1cd47c3094fe6ef98c4212b557255e93bcaff8ce is the first bad commit commit 1cd47c3094fe6ef98c4212b557255e93bcaff8ce (HEAD) Author: Keno Fischer