search

JuliaLang / juliaup

Julia installer and version multiplexer
MIT License
976 stars 82 forks source link

Hope to display the percentage of progress #971

Open zsz00 opened 2 months ago

zsz00 commented 2 months ago

~$ juliaup up Installing Julia 1.11.0-rc1+0.x64.linux.gnu Downloading: [===========> ] 142.84 MiB/239.31 MiB eta: 2m

Hope to display the percentage of progress: Downloading: 63% [===========> ] 142.84 MiB/239.31 MiB eta: 2m

christiangnrd commented 2 weeks ago

This would be a very easy PR. Just change this line to

.template("{prefix:.cyan.bold} {percent}% [{bar}] {bytes}/{total_bytes} eta: {eta}")

However, this seems a bit busy to me. Do we really need both percentage and bytes? Plus having the percentage of the left makes the progress bar move when the number of digits changes.

Personally, I prefer the bar how it is with the bytes.