search

JuliaLang / libuv

Cross-platform asynchronous I/O
http://libuv.org/
MIT License
9 stars 14 forks source link

Backport win,tty fixes for Windows systems #11

Closed musm closed 4 years ago

musm commented 4 years ago

Backport several patches. These changes help to enable and support VT sequences on Windows.

musm commented 4 years ago

The last two commits are not necessary, but I think they can't hurt to add. I'm happy to remove them if desired.

musm commented 4 years ago

@vtjnash What do think about this, Is this ok to merge or do you have bigger concerns? I'd like to also get in https://github.com/libuv/libuv/pull/2910 eventually when that get's merged upstream.

StefanKarpinski commented 4 years ago

Would be great to get this merged.

musm commented 4 years ago

merging in a few days sans objections

vtjnash commented 4 years ago

It looks like I previously either authored or reviewed each of these, so I guess I'm on board.

musm commented 4 years ago

merge commit / squash and merge / rebase and merge?

I'm guessing rebase and merge?

vtjnash commented 4 years ago

That'd be fine, and probably clearest in the history log

c42f commented 4 years ago

Fantastic, thanks @musm. I've hit many problems with VT support on windows which really can't be worked around. I think this will sort them out.