win,tty: pass through utf-16 surrogate pairs

JuliaLang / libuv

Cross-platform asynchronous I/O

http://libuv.org/

MIT License

9 stars 14 forks source link

win,tty: pass through utf-16 surrogate pairs #13

Closed musm closed 4 years ago

musm commented 4 years ago

On Windows allow utf-16 surrogate pars to pass through, which allows conhost on newer Windows versions and other terminal emulators to be able to render them.

Fixes: https://github.com/libuv/libuv/issues/2909 PR-URL: https://github.com/libuv/libuv/pull/2971 Reviewed-By: Ben Noordhuis info@bnoordhuis.nl Reviewed-By: Jameson Nash vtjnash@gmail.com (cherry picked from commit aa4fcc49a29bb55928d5d519c179a1ba3f9d71b7)

musm commented 4 years ago

@vtjnash can I just go ahead and merge this ? You already reviewed the upstream PR, so I don't see any reason to hold up things up.

Eventually this will all be superseded by your upgrade to libuv, but until then we might as well have it on master.

vtjnash commented 4 years ago

Yes

vtjnash commented 4 years ago

There’s one more commit from upstream we should add and backport too.

musm commented 4 years ago

There’s one more commit from upstream we should add and backport too.

Which one?