search

JuliaLang / libuv

Cross-platform asynchronous I/O
http://libuv.org/
MIT License
9 stars 14 forks source link

Unpoison the statx buffer for MSAN #26

Closed gbaraldi closed 2 years ago

gbaraldi commented 2 years ago

Could we merge this? Checking for success inside the function that does the syscall doesn't seem to be how LibUV usually does it.

vtjnash commented 2 years ago

Here is how libuv usually handles MSAN (prior to deleting this code and using the glibc wrapper instead), as Keno said: https://github.com/bnoordhuis/libuv/commit/233490819ca4010d0db70a0ae411ae9f73571baa

vtjnash commented 2 years ago

c.f. https://github.com/libuv/libuv/pull/311

Keno commented 2 years ago

At least I'm consistent ;)

bnoordhuis commented 2 years ago

I've opened https://github.com/libuv/libuv/pull/3788 to address this, also for getrandom() (edit: but not yet recvmmsg.)

gbaraldi commented 2 years ago

Do we backport/pull the upstream changes, or do we wait for an upstream release? @vtjnash ?