Closed nalimilan closed 6 years ago
Would it be possible to add some timings to the kinds of code patterns that have been reported to be slow - like John Myles White's blog etc.? Just @time ...
to show how fast things are.
If there are obvious comparisons that can be done with R and Python missing value handling, that would be of broader interest to readers who are not already Julia users - but that may be a bit more work.
Would it be possible to add some timings to the kinds of code patterns that have been reported to be slow - like John Myles White's blog etc.? Just @time ... to show how fast things are.
I'll have a look. Hopefully my claims will be confirmed... :-p
If there are obvious comparisons that can be done with R and Python missing value handling, that would be of broader interest to readers who are not already Julia users - but that may be a bit more work.
What kind of comparison do you have in mind? I tend to think the examples are simple enough that readers should be able to identify the equivalent in languages they know very easily.
I've added benchmarks now that inlining works (https://github.com/JuliaLang/julia/pull/27651), and improved a few things. More comments before merging?
Could you change the ack to be more the standard academic language ("thanks X, Y and Z for input, not implying they agree" bla bla)? The current version reads a bit as if there was a consensus about the design, which at least in my case is not the case.
Can you suggest a wording? I think apart from you the other people I've cited generally agree with the design. I can put you in a separate sentence if you prefer, though it could sound a bit weird.
I don't really care what language you use, as long as you don't give the impression that I'm on board with this design.
I don't really care what language you use, as long as you don't give the impression that I'm on board with this design.
Precisely, I don't know how to phrase that. Currently I just say you participated in discussions.
I've tried something, please tell me whether it's OK for you.
I'll merge tomorrow if there are no additional comments.
Sounds good, thanks!
As promised a long time ago.
Comments welcome on contents, technical details, phrasing, presentation, etc.