search

JuliaLinearAlgebra / AlgebraicMultigrid.jl

Algebraic Multigrid in Julia
Other
117 stars 23 forks source link

A no-op condition #40

Closed mohamed82008 closed 6 years ago

mohamed82008 commented 6 years ago

https://github.com/JuliaLinearAlgebra/AlgebraicMultigrid.jl/blob/061a5418f04ffac9eeac4566ec00d378bdf1cf72/src/splitting.jl#L68

The second part of the above condition (lambda[i] == 1 && Tj[Tp[i]] == i) will always be false since we dropped the diagonal elements of S earlier so even if there exists one off-diagonal element in the ith column of S, i.e. lambda[i] == 1, this element will not be a diagonal element, i.e. Tj[Tp[i]] == i is false.

ranjanan commented 6 years ago

Yeah, some of the classical AMG code needs to be rewritten.