search

JuliaLinearAlgebra / AlgebraicMultigrid.jl

Algebraic Multigrid in Julia
Other
117 stars 22 forks source link

Bring back the kwargs - smoothed aggregation #58

Closed mohamed82008 closed 3 years ago

mohamed82008 commented 5 years ago

This probably fixes a typo.

mancolric commented 4 years ago

I think @mohamed82008 suggestion has gone unnoticed, as it has not been merged into the master branch yet. I had to manually change this in my computer to make the keywords work. In addition, the ruge_stuben method in "classical.jl" does have a semicolon before the keywords, so this function should have as well for consistency.

By the way, where can I find some documentation about this package?? For the moment I have to manually inspect all the files and guess how the keywords work, as I have not found any documentation.

ViralBShah commented 3 years ago

@ranjanan Can we merge this?

DilumAluthge commented 3 years ago

Might be good to rebase so that the GHA CI can run?

mohamed82008 commented 3 years ago

I forgot about this one! I can rebase it.

ranjanan commented 2 years ago

Thanks @mohamed82008.

ViralBShah commented 2 years ago

Maybe good to go to v0.5. given that this is an API change. It is not breaking, but easier for packages to depend on a new minor version.