Unqualified overload of Base.length leads to confusing LoadErrors

JuliaLinearAlgebra / AlgebraicMultigrid.jl

Algebraic Multigrid in Julia

Other

117 stars 22 forks source link

Unqualified overload of Base.length leads to confusing LoadErrors #59

Closed jagot closed 2 years ago

jagot commented 5 years ago

Since this package overloads Base.length, without specifying ml::MultiLevel as the argument type, you get weird LoadErrors if you have this package loaded and you call length on a object which has no method defined. E.g. length(nothing) results in

ERROR: LoadError: type Nothing has no field levels

ViralBShah commented 2 years ago

Should be fairly straightforward to rename length to something else. Hopefully a quick search and replace.

fredrikekre commented 2 years ago

https://github.com/JuliaLinearAlgebra/AlgebraicMultigrid.jl/pull/64