search

JuliaLinearAlgebra / AlgebraicMultigrid.jl

Algebraic Multigrid in Julia
Other
116 stars 23 forks source link

Make AMG thread safe #68

Closed ranjanan closed 3 years ago

ranjanan commented 3 years ago

Create nthreads() scratch spaces.

mohamed82008 commented 3 years ago

Would be nice to run a small benchmark to make sure the performance didn't drop for a single thread.

ViralBShah commented 3 years ago

Say I have 4 cores, and hence 4 threads, but I spawn 100 solves. Won't those 100 solves be concurrently updating this data structure, unless you schedule the solves to ensure that each processor is only working on one solve at a time?

ViralBShah commented 3 years ago

Sorry I accidentally clicked merge. I have reverted it, but you may need to open a new PR. Hope that's ok. I do think that this PR does not fix the issue.

ViralBShah commented 3 years ago

Let's continue this discussion in the upstream circuitscape repo.