search

JuliaLinearAlgebra / AlgebraicMultigrid.jl

Algebraic Multigrid in Julia
Other
116 stars 23 forks source link

CompatHelper: bump compat for "IterativeSolvers" to "0.9" #70

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 3 years ago

This pull request changes the compat entry for the IterativeSolvers package from 0.8.3 to 0.8.3, 0.9.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

ChrisRackauckas commented 3 years ago

This should get a quick merge. It's just a compat change to 5-arg mul!.

mohamed82008 commented 3 years ago

The test failure here seems to imply an API change.

mohamed82008 commented 3 years ago

it's just that tol is not a valid kwarg anymore.

ranocha commented 3 years ago

Since #71 is merged and the compat entry for IteraiveSolvers.jl is changed there, could you please close this PR and release a new version of AlgebraicMultigrid.jl?

ViralBShah commented 2 years ago

Yes it is time to release a new version.

ViralBShah commented 2 years ago

I think we should bump deps up to new versions and Julia to 1.6 after deciding on the other PRs and then tag a new release. @ranjanan what do you think?

ranjanan commented 2 years ago

The current Project.toml entry for IterativeSolvers is already at 0.9. Julia hasn't been bumped to 1.6 though. Will do that.

ranjanan commented 2 years ago

Julia deps updated to 1.6 and IterativeSolvers to 0.9, so closing this