search

JuliaLinearAlgebra / AppleAccelerate.jl

Julia interface to the macOS Accelerate framework
Other
96 stars 18 forks source link

MassInstallAction: Install the CI workflow on this repository #41

Closed timholy closed 1 year ago

timholy commented 3 years ago

This pull request sets up the CI workflow on this repository.

codecov[bot] commented 3 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@d79efa2). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 34c9c7b differs from pull request most recent head 1dd3774. Consider uploading reports for the commit 1dd3774 to get more accurate results

@@            Coverage Diff            @@
##             master      #41   +/-   ##
=========================================
  Coverage          ?   80.64%           
=========================================
  Files             ?        3           
  Lines             ?      124           
  Branches          ?        0           
=========================================
  Hits              ?      100           
  Misses            ?       24           
  Partials          ?        0

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ViralBShah commented 1 year ago

The tests run fine locally for me, but not in CI. @daviehh Since you provided the PR that made this package run on my mac, I wonder if you have any thoughts here.

ViralBShah commented 1 year ago

Merging this to switch on the CI, and subsequent PRs need to make the CI pass.

ViralBShah commented 1 year ago

@giordano @staticfloat Would you know why these tests that are basically dlopening Accelerate and calling simple functions, failing in CI, but would pass locally?

daviehh commented 1 year ago

According to the report in https://github.com/JuliaMath/AppleAccelerate.jl/pull/43#issuecomment-1101479528, it may be a macos bug: some version in of macos 11.x may have some bugs that missed some symbols; all test runs fine on 12.x