search

JuliaLinearAlgebra / AppleAccelerate.jl

Julia interface to the macOS Accelerate framework
Other
96 stars 18 forks source link

Convolution + Corrrelation + Types for Testing #8

Closed rprechelt closed 8 years ago

rprechelt commented 8 years ago

Another PR! This one contains the following:

  1. conv: Convolution for Float64 and Float32 (initial profiling indicates that AppleAccelerate.conv is 23 times faster than Base.conv, and allocates 6 times less memory, for two arrays of length 100)
  2. xcorr: Cross-correlation and auto-correlation for Float32 and Float64
  3. Tests for the above functions for both types. I also noticed that the existing test suite did not contain testing for Float32. I made further enhancements to the existing tests so that they explicitly run on Float32 and Float64 and that this information is included in any error messages that are produced.

Travis Results

  1. v0.4: All tests pass.
  2. v0.5: The sin test in @replaceBase (the start of all of this testing rewrite) still fails on Travis; all other tests pass. I've run it on three separate machines on both OS X and Ubuntu and the test always passes for me. At this point, I'm at a loss as for why it is failing in Travis but not locally. If you have any advice here, it would be most appreciated.

Updated the .travis.yml per tkelman's suggestion (this is the cause of the merge).

simonbyrne commented 8 years ago

This needs to be rebased against the master branch.

rprechelt commented 8 years ago

Will do; probably have it done tomorrow.

On Tuesday, March 8, 2016, Simon Byrne notifications@github.com wrote:

This needs to be rebased against the master branch.

— Reply to this email directly or view it on GitHub https://github.com/JuliaLang/AppleAccelerate.jl/pull/8#issuecomment-193940899 .

rprechelt commented 8 years ago

Rebased.

simonbyrne commented 8 years ago

Fantastic, thanks!

simonbyrne commented 8 years ago

@rprechelt I've added you as a collaborator, so you now have commit access.

rprechelt commented 8 years ago

@simonbyrne thanks for the collaborator status! I have a couple of features already in mind that I am going to start working on next week; totally committed to making this package be as good as can be!

tkelman commented 8 years ago

First tagged version that includes this change to minimum julia version in REQUIRE should use a new package minor version number via Pkg.tag("AppleAccelerate", :minor).

simonbyrne commented 8 years ago

Done: see https://github.com/JuliaLang/METADATA.jl/pull/4742