search

JuliaLinearAlgebra / ArrayLayouts.jl

A Julia package for describing array layouts and more general fast linear algebra
https://julialinearalgebra.github.io/ArrayLayouts.jl/
MIT License
56 stars 10 forks source link

Add * for more matrices defined from layouts #241

Closed DanielVandH closed 4 months ago

DanielVandH commented 4 months ago

Need this to support multiplication between infinite matrices, as found in https://github.com/DanielVandH/InfiniteRandomArrays.jl/issues/5.

To make sure the methods are being tested properly, I extended the minimal InfiniteArrays.jl module in the tests to include a (hopefully minimal) definition of an infinite vector and an infinite matrix, and the resulting named matrices to mimic those from InfiniteRandomMatrices.jl.

InfVec and InfMat were initially just matrices which returned the indices, e.g. InfVec()[i] = i, but I wanted to be sure the methods were properly copying the data and accessing the correct entries, so I convert it into a random vector.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.53%. Comparing base (d315ce3) to head (33a160e).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #241 +/- ## ========================================== + Coverage 90.43% 90.53% +0.10% ========================================== Files 11 11 Lines 1902 1923 +21 ========================================== + Hits 1720 1741 +21 Misses 182 182 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

DanielVandH commented 4 months ago

I'll deal with LTS later