Open jishnub opened 2 months ago
Attention: Patch coverage is 0%
with 23 lines
in your changes missing coverage. Please review.
Project coverage is 0.00%. Comparing base (
d315ce3
) to head (77bfc17
).
Files | Patch % | Lines |
---|---|---|
src/diagonal.jl | 0.00% | 23 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (d315ce3) and HEAD (77bfc17). Click for more details.
HEAD has 7 uploads less than BASE
| Flag | BASE (d315ce3) | HEAD (77bfc17) | |------|------|------| ||12|5|
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Currently, there are method ambiguities on v1.10, because of which these paths were not being tested. These ambiguities are resolved on the currently nightly, which reveals a stack-overflow in these methods. This arises because an operation like
internally calls
but this method was calling
D * B
again, leading to a cycle. To avoid this, we now broadcastD.diag
over the other matrix. The added tests all work on nightly where there are no method ambiguities anymore, and theBidiagonal
ones work on current versions as well.