JuliaLinearAlgebra / BLISBLAS.jl

BLIS-pendant of MKL.jl
MIT License
11 stars 4 forks source link

Upgrade BLISBLAS.jl #6

Open amontoison opened 1 year ago

amontoison commented 1 year ago

@carstenbauer I compiled an LP64 version of BLIS with Yggdrasil. With Julia 1.9, we should be able to combine them with LAPACK_jll and LAPACK32_jll.

codecov[bot] commented 1 year ago

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (b6764e5) to head (db7ad21). Report is 7 commits behind head on main.

Files Patch % Lines
src/BLISBLAS.jl 0.00% 11 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6 +/- ## ========================================== - Coverage 91.66% 0.00% -91.67% ========================================== Files 1 1 Lines 12 20 +8 ========================================== - Hits 11 0 -11 - Misses 1 20 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

amontoison commented 1 month ago

@carstenbauer I updated this PR because some users wanted to try it in Ipopt.jl. Here are a few key points:

carstenbauer commented 1 month ago

Haven't reviewed this yet but note that almost all CI runs are failing. Can you address those failures first?

amontoison commented 1 month ago

Haven't reviewed this yet but note that almost all CI runs are failing. Can you address those failures first?

The issues seem related to blis. Since the OpenBLAS backend wasn't cleared, blis symbols were never used. I opened PR #18 to verify it.

It turns out that using BLISBLAS.jl didn't change the default BLAS backend before this PR.