JuliaLinearAlgebra / BlockBandedMatrices.jl

A Julia package for representing block-banded matrices and banded-block-banded matrices
https://julialinearalgebra.github.io/BlockBandedMatrices.jl/
MIT License
58 stars 13 forks source link

Move BandedMatrices+BlockArrays to BlockArray extension #195

Closed dlfivefifty closed 5 months ago

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 95.45455% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.53%. Comparing base (1425899) to head (33fe6b9). Report is 1 commits behind head on release-0.13.

Files Patch % Lines
src/BandedBlockBandedMatrix.jl 88.88% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## release-0.13 #195 +/- ## ================================================ + Coverage 88.37% 89.53% +1.15% ================================================ Files 11 11 Lines 1204 1108 -96 ================================================ - Hits 1064 992 -72 + Misses 140 116 -24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

jishnub commented 5 months ago

Let's create a release-0.13 branch, as this would simplify collecting all the changes.

Edit: I've created one now. Would you mind changing the target branch for this PR?

dlfivefifty commented 5 months ago

Done. But what else is going in release-0.13?

jishnub commented 5 months ago

There are some other minor changes that might be useful, like not exporting Zeros/Ones/Fill/Block and asking users to import these from the corresponding packages.

dlfivefifty commented 5 months ago

What's wrong with exporting them?

jishnub commented 5 months ago

It just makes the package more prone to breakages, as breaking changes upstream get translated to this package as well, which shouldn't be the case usually. Typically, one may bump the minor or patch version of a package to incorporate a breaking version of a dependency.

dlfivefifty commented 5 months ago

ok I see your point