search

JuliaLinearAlgebra / HierarchicalMatrices.jl

Julia package for hierarchical matrices
Other
26 stars 5 forks source link

HierarchicalMatrices should use BlockArrays #4

Open dlfivefifty opened 6 years ago

dlfivefifty commented 6 years ago

BlockArrays has a well-developed block matrix structure, so this would avoid needing your own Block.

MikaelSlevinsky commented 6 years ago

You're talking mainly about the abstract block array interface, and not the concrete block array type, right? AFAICT, hierarchical matrices are block arrays where the blocks are different types, but this is staged for performance. On the other hand, the concrete block array type has templated the block type. I don't see how a getindex on the blocks would ever be performant for hierarchical matrices due to the type instability. setindex!, though is type stable.

dlfivefifty commented 6 years ago

I meant HierarchicalMatrix{T} <: AbstractBlockMatrix{T}.