search

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems
MIT License
401 stars 106 forks source link

Remove plotting from this package #172

Closed haampie closed 6 years ago

haampie commented 6 years ago

I'm not sure what the general opinion is about this, but I feel the dependencies on UnicodePlots and RecipesBase are odd.

Do we really need plotting? Considering you typically only plot the residual norm of each iteration, what's wrong with writing

using Plots
x, history = gmres(A, b, log = true)
plot(history[:resnorm], yscale = :log10)

Furthermore, plotting and ConvergenceHistory objects in general are not tested.

If we really want to have it, maybe it can be moved to another repository like IterativeSolversTools.jl as well.

ChrisRackauckas commented 6 years ago

I think the UnicodePlots dependency is a little odd, especially with the recipe already existing. But RecipesBase is essentially 1 macro and widely used. At this point I wouldn't consider it much of a dependency as much of a part of basic Julia.

haampie commented 6 years ago

Thanks @ChrisRackauckas, I think you're right