search

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems
MIT License
401 stars 106 forks source link

Type instability in cg #194

Closed mohamed82008 closed 6 years ago

mohamed82008 commented 6 years ago

https://github.com/JuliaMath/IterativeSolvers.jl/blob/756edef2b6a58a65b41f87127fbec1f8c62150c7/src/cg.jl#L203 The above line creates a type instability. Can be fixed by making log::Type{Val{logging}} and making logging a type parameter.

andreasnoack commented 6 years ago

Remember that we've constant propagation on 0.7 so I wouldn't use any Val for this.

haampie commented 6 years ago

Duplicate of #192. See also #185.