search

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems
MIT License
401 stars 106 forks source link

Bring back 5-arg `mul!` to lsmr #206

Open haampie opened 6 years ago

haampie commented 6 years ago

In #205 I have temporarily removed the 5-argument mul!(y, A, x, a, b) calls from lsmr, since there is no implementation for dense A. It worked becauselsmr implemented it itself, but I guess nobody wants IterativeSolvers.jl to extend LinearAlgebra.mul!.

Let's wait till we have the 5-argument mul! in LinearAlgebra and bring it back to lsmr only then.

lostella commented 5 years ago

Not sure this is ever coming back. We may want to consider using LinearAlgebra.BLAS.gemv! instead.

andreasnoack commented 5 years ago

Please avoid calling the BLAS wrappers directly if possible. It would be better to call a generic version.

chriscoey commented 5 years ago

it is endlessly frustrating that we don't have an efficient generic in-place 5 argument mul! in Julia

chriscoey commented 5 years ago

https://github.com/JuliaLang/julia/pull/29634 has been merged (huzzah!) hence we can now use 5-arg mul!