search

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems
MIT License
399 stars 105 forks source link

fix idrs! when near solution #253

Closed platawiec closed 5 years ago

platawiec commented 5 years ago

Fixes #222

codecov-io commented 5 years ago

Codecov Report

Merging #253 into master will increase coverage by 0.09%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #253      +/-   ##
==========================================
+ Coverage   90.52%   90.62%   +0.09%     
==========================================
  Files          17       17              
  Lines        1077     1077              
==========================================
+ Hits          975      976       +1     
+ Misses        102      101       -1
Impacted Files Coverage Δ
src/idrs.jl 91.93% <100%> (+1.61%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17ef261...88e614c. Read the comment docs.

mschauer commented 5 years ago

Looks good, even with a Test! Is any of the bookkeeping 

            shrink!(log)
        setconv(log, 0<=normR<tol)
        setmvps(log, iter)

needed/useful for this early break?

platawiec commented 5 years ago

Good point, I had a look. Only setconv seems necessary In fact, there was an extraneous call to shrink! which I removed.

chriscoey commented 5 years ago

bump

mschauer commented 5 years ago

bump?

mschauer commented 5 years ago

Planning to merge after the weekend.