use LinearAlgebra's new generic in-place 5-arg mul! wherever possible (requires Julia 1.3)

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems

MIT License

399 stars 105 forks source link

use LinearAlgebra's new generic in-place 5-arg mul! wherever possible (requires Julia 1.3) #254

Open chriscoey opened 5 years ago

chriscoey commented 5 years ago

see https://github.com/JuliaLang/julia/pull/29634

this will fix #206, #245 and is relevant to #251, #248

davidschlegel commented 3 years ago

I think this will also fix #295 .

ranocha commented 3 years ago

I think #295 will also require updates of lines like https://github.com/JuliaLinearAlgebra/IterativeSolvers.jl/blob/ae01dfe228138d0db9164eb343252150f6c0bfc6/src/bicgstabl.jl#L37-L40

davidschlegel commented 3 years ago

Yes, and probably at some other lines. I am not familiar with the code, so I think I cannot really help here, but I would love to have this fixed. The cg function already has the functionality to work with CUDA types, and so I think it should be possible to do it here are well. #295