WIP: Replaced BLAS calls with generic equivalents from LinearAlgebra

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems

MIT License

399 stars 105 forks source link

WIP: Replaced BLAS calls with generic equivalents from LinearAlgebra #261

Closed jbmuir closed 3 years ago

jbmuir commented 4 years ago

This answers the letter but not the spirit of #251 and to an extent #245; there remain instances where matrices are created on the cpu (e.g. creating the ArnoldiDecomp for gmres) which remain to be resolved. This is my first ever PR so please let me know if I've stuffed something up!

ChrisRackauckas commented 4 years ago

there remain instances where matrices are created on the cpu (e.g. creating the ArnoldiDecomp for gmres)

Might need to use Adapt.jl

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 444158272

0 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 96.528%

Totals
Change from base Build 444145887:	0.0%
Covered Lines:	1835
Relevant Lines:	1901

💛 - Coveralls

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 444158272

8 of 8 (100.0%) changed or added relevant lines in 4 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+1.01%) to 97.539%

Totals
Change from base Build 444145887:	1.01%
Covered Lines:	1744
Relevant Lines:	1788