Closed oscarvanderheide closed 1 month ago
When I run lsqr on CuArrays, the lines
lsqr
CuArray
for i = 1:n isfinite(x[i]) || error("Initial guess for x must be finite") end
result in poor performance due to scalar indexing. I replaced this with
if !(all(isfinite.(x))) error("Initial guess for x must be finite") end
but before I submit a PR I thought it would be better to file and issue and discuss potential implications of the proposed approach.
The implementation of lsqr in Krylov.jl works on GPUs if it can help.
When I run
lsqr
onCuArray
s, the linesresult in poor performance due to scalar indexing. I replaced this with
but before I submit a PR I thought it would be better to file and issue and discuss potential implications of the proposed approach.