Modification to prevent scalar indexing on CUDA devices

JuliaLinearAlgebra / IterativeSolvers.jl

Iterative algorithms for solving linear systems, eigensystems, and singular value problems

MIT License

403 stars 106 forks source link

Modification to prevent scalar indexing on CUDA devices #362

Closed oscarvanderheide closed 2 months ago

oscarvanderheide commented 4 months ago

Scalar indexing on CUDA devices results in poor performance. This modification uses dot syntax to prevent scalar indexing.

coveralls commented 4 months ago

Pull Request Test Coverage Report for Build 9110126882

Details

1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.1%) to 97.596%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/lsqr.jl	1	2	50.0%
<!--	Total:	1	2	50.0%	-->

Totals
Change from base Build 7903548867:	0.1%
Covered Lines:	2030
Relevant Lines:	2080

💛 - Coveralls

oscarvanderheide commented 2 months ago

Would it be possible to have this change merged now that it is approved? I see a check related to documentation is unsuccessful but I don't think it it is related to the change in this pull request?