JuliaLinearAlgebra / LinearMaps.jl

A Julia package for defining and working with linear maps, also known as linear transformations or linear operators acting on vectors. The only requirement for a LinearMap is that it can act on a vector (by multiplication) efficiently.

Other

303 stars 42 forks source link

Check output size for FunctionMaps #161

Closed JeffFessler closed 3 years ago

JeffFessler commented 3 years ago

Closes #160.

Hopefully I found all the (non-mutating) cases where this check is relevant.

codecov[bot] commented 3 years ago

Codecov Report

Merging #161 (961bebe) into master (744800a) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master     #161   +/-   ##
=======================================
  Coverage   99.42%   99.43%           
=======================================
  Files          14       14           
  Lines        1051     1056    +5     
=======================================
+ Hits         1045     1050    +5     
  Misses          6        6

Impacted Files	Coverage Δ
src/functionmap.jl	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 744800a...961bebe. Read the comment docs.

JeffFessler commented 3 years ago

Sure! The funny thing is that there was a A.N earlier in that function so I was trying to be consistent with that, but now I see that the various functions were sometimes using A.N and A.M and sometimes using size. Now I think I've made them all consistent.

dkarrasch commented 3 years ago

This looks good. I rerun the tests to see if some issue on master got fixed meanwhile. @JeffFessler Could you please bump the patch version (I consider this a bugfix)?

JeffFessler commented 3 years ago

the nightly fail is due to some type inference problem it seems

dkarrasch commented 3 years ago

the nightly fail is due to some type inference problem it seems

Yes, I could reproduce that locally. It seems there is a magic number of arguments when it fails, like, the test two lines above the failing one (an hcat with three less map arguments) doesn't fail. Perhaps we need an issue upstream.