Closed oschulz closed 1 year ago
Thank you very much! Do you understand the complaint by Aqua.jl
? Do we need to move the additions to Project.toml
to a different place? The load time gain is great. Looks like almost all the load time is spent on ChainRulesCore
?
@dkarrasch The Aqua think I had hoped was handled now, but apparently not yet. It's just that Julia v1.6 formats Project.toml differently if there are weakdeps entries (which it doesn't know about) in it. So the Project.toml formatting tests has to be disabled on v1.6.
The invalidations failure seems unavoidable with Pkg extensions right now, see PainterQubits/Unitful.jl#652 .
Aqua tests should pass now, hopefully.
Patch coverage has no change and project coverage change: +0.26
:tada:
Comparison is base (
50ace9c
) 99.41% compared to head (adfd37e
) 99.67%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@dkarrasch This should be it now - from what I understand, the invalidations failure has to be ignored for now until with Pkg extensions, until that's handled upstream.
Could you please bump the patch number and then I'll release shortly after merging. Thanks again!
Version is bumped, thanks @dkarrasch !
Substantially reduces the load time of LinearMaps on Julia v1.9.
Before:
After: