Closed dkarrasch closed 1 year ago
Patch coverage: 100.00
% and no project coverage change.
Comparison is base (
f522a8f
) 99.67% compared to head (98d1014
) 99.67%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@oschulz This should help your package, shouldn't it? It seems like your package doesn't depend on SparseArrays.jl, so you would avoid loading it, at least via LinearMaps.jl.
@oschulz This should help your package, shouldn't it?
Yes, definitely! I have this MatrixLikeOperator
in there only to keep load time down and to experiment with an operator that subtypes AbstractMatrix
. I currently use LinearMaps via an extension - as soon as a `MatrixLikeOperator
is multipled with a LinearOperator
the result is "promoted" to a LinearOperator
. But if LinearOperators
becomes even more lightweight I may be able to throw this MatrixLikeOperator
out completely.
Nice, LinearMaps loads in 19 ms now. :-)
Are you tagging a new relase with this @dkarrasch ?
This handles the two dependencies
SparseArrays.jl
andStatistics.jl
as weak dependencies. Indeed, the only reason LinearMaps.jl depended on these was to overload their functions. Otherwise, LinearMaps.jl has always been independent from these two. Moreover, users could not call, say,sparse
without loadingSparseArrays.jl
, so this is a clear case. This brings package load time of pureLinearMaps.jl
down to below 20 ms (from about 300 ms, if not 500 ms and more) on current Julia nightly with SparseArrays.jl out of the sysimage).Resolves #207.