Closed dkarrasch closed 1 year ago
Patch coverage: 100.00
% and project coverage change: +0.01
:tada:
Comparison is base (
b6b1044
) 99.67% compared to head (fd150d4
) 99.68%.:exclamation: Current head fd150d4 differs from pull request most recent head bfaefd5. Consider uploading reports for the commit bfaefd5 to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
The fallback code for general types might have been simpler if we allowed A[i,i]
🥲
True, but less efficient, because how would you reuse the canonical vector?
I wonder if we should have some kind of iterator for iterating all canonical vectors, though. Let me think about it...
Ah yes, fair point.
Some users expressed interest in the trace function, so here we go. In the generic case, this is, of course, expensive, but in some cases we may leverage the lazy structure and algebraic rules to compute the trace allocation-free, like in the (lazy) Kronecker product of two square matrices. Another included classic use case is (lazy) rank-one matrices.