search

JuliaLinearAlgebra / LinearMaps.jl

A Julia package for defining and working with linear maps, also known as linear transformations or linear operators acting on vectors. The only requirement for a LinearMap is that it can act on a vector (by multiplication) efficiently.
Other
303 stars 42 forks source link

Fix some method signatures related AbstractQ's #211

Closed dkarrasch closed 9 months ago

dkarrasch commented 10 months ago

AbstractQ used to subtype AbstractMatrix, but since Julia v1.10 no longer does. This fixes a few method signatures in places where we do want to include AbstractQs (usually where they get wrapped by WrappedMap). This does not include things like mul!(Y, A::LinearMap, Q::AbstractQ).

Depends on https://github.com/JuliaLang/julia/pull/51132.

Closes #214.

codecov[bot] commented 10 months ago

Codecov Report

All modified lines are covered by tests :white_check_mark:

Comparison is base (bdbfe00) 99.68% compared to head (715bee6) 99.68%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #211 +/- ## ======================================= Coverage 99.68% 99.68% ======================================= Files 22 22 Lines 1591 1591 ======================================= Hits 1586 1586 Misses 5 5 ``` | [Files](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra) | Coverage Δ | | |---|---|---| | [src/blockmap.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2Jsb2NrbWFwLmps) | `100.00% <100.00%> (ø)` | | | [src/fillmap.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2ZpbGxtYXAuamw=) | `100.00% <100.00%> (ø)` | | | [src/getindex.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2dldGluZGV4Lmps) | `100.00% <100.00%> (ø)` | | | [src/left.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL2xlZnQuamw=) | `100.00% <100.00%> (ø)` | | | [src/uniformscalingmap.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL3VuaWZvcm1zY2FsaW5nbWFwLmps) | `100.00% <100.00%> (ø)` | | | [src/wrappedmap.jl](https://app.codecov.io/gh/JuliaLinearAlgebra/LinearMaps.jl/pull/211?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=JuliaLinearAlgebra#diff-c3JjL3dyYXBwZWRtYXAuamw=) | `100.00% <100.00%> (ø)` | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.