search

JuliaLinearAlgebra / MKL.jl

Intel MKL linear algebra backend for Julia
Other
208 stars 32 forks source link

Ignore environment changes in CI #132

Closed imciner2 closed 1 year ago

imciner2 commented 1 year ago

The test suite needs to ignore any changes to the environment because loading MKL's shared library on some platforms (such as Windows) can create environment variables for OpenMP (e.g. __KMP_REGISTEREDLIB) that live the entire Julia session and make the environment appear modified.

This should fix the Windows CI, but the other ones will still probably fail.

Fixes #130

imciner2 commented 1 year ago

Ok, turns out the fix must be more complicated than just getting Github actions to set that environment variable.

How do the environment variables propagate to any subprocesses that are spawned? It looks like these MKL tests actually run Julia again, and that julia subprocess is where the environment variable actually needs to be set. It looks like we could modify the run call to do a addenv on the new Julia environment, but I am just surprised it apparently isn't inherited from the current environment.