search

JuliaLinearAlgebra / MKL.jl

Intel MKL linear algebra backend for Julia
Other
208 stars 32 forks source link

Remove manual mapping of non-suffixed APIs, which is fixed in MKL 2024.1 #167

Closed ViralBShah closed 5 months ago

ViralBShah commented 5 months ago

Discussion in https://github.com/JuliaLinearAlgebra/MKL.jl/pull/140#issuecomment-2110250127.

Bumping to 2024.1 will also drop support for MKL on Mac, and threading tests fail on Julia 1.8. As a result Julia 1.9 is the new minimum. As a result, bumping the version to 0.7.

cc @amontoison

amontoison commented 5 months ago

@ViralBShah I am worried for https://github.com/JuliaLinearAlgebra/MKL.jl/pull/164#issuecomment-2110251418. I don't want to break things for Ipopt users.

ViralBShah commented 5 months ago

I suppose I should just go ahead and remove macOS-13 from CI, since we no longer have support for macs. It would be nice if it just ended up with MKL_jll not available (like on macOS-14) rather than the Pkg error we get now.

giordano commented 5 months ago

We can have a step which installs an older MKL_jll for macos-13.

ViralBShah commented 5 months ago

We can have a step which installs an older MKL_jll for macos-13.

Those won't have the dlamch_64 etc. that only got done in 2024.1. I think folks who want Intel Macs may be best off using an older version of MKL.jl. Is there a way to make that happen?

We already have a note in the README: https://github.com/JuliaLinearAlgebra/MKL.jl?tab=readme-ov-file#note-mkl-on-intel-macs

ViralBShah commented 5 months ago

We should probably add a couple of simple LP64 BLAS tests to make sure we don't regress.