JuliaLinearAlgebra / MatrixDepot.jl

An Extensible Test Matrix Collection for Julia
http://matrixdepotjl.readthedocs.org/
Other
75 stars 22 forks source link

ignore cached db if not readable #42

Closed KlausC closed 4 years ago

KlausC commented 4 years ago

Fixes #40. Also add Project.toml.

KlausC commented 4 years ago

Failing tests because of missing network connectivity on Linux nodes of travis.

andreasnoack commented 4 years ago

Could you please rebase this one?

codecov[bot] commented 4 years ago

Codecov Report

Merging #42 into master will decrease coverage by 0.19%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #42     +/-   ##
=========================================
- Coverage   90.93%   90.74%   -0.2%     
=========================================
  Files          12       12             
  Lines        1876     1945     +69     
=========================================
+ Hits         1706     1765     +59     
- Misses        170      180     +10
Impacted Files Coverage Δ
src/types.jl 62.28% <0%> (-7.9%) :arrow_down:
src/MatrixDepot.jl 95.45% <0%> (-4.55%) :arrow_down:
src/matrixmarket.jl 91.4% <0%> (-1.53%) :arrow_down:
src/download.jl 92.07% <0%> (-0.89%) :arrow_down:
src/common.jl 96.81% <0%> (+0.02%) :arrow_up:
src/datareader.jl 88.31% <0%> (+0.15%) :arrow_up:
src/higham.jl 94.63% <0%> (+0.16%) :arrow_up:
src/regu.jl 92.23% <0%> (+0.36%) :arrow_up:
src/markdown.jl 98.7% <0%> (+1.51%) :arrow_up:
src/logical.jl 71.28% <0%> (+7%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 96353db...6d6d161. Read the comment docs.

KlausC commented 4 years ago

This is a bug fix, could it be merged?

andreasnoack commented 4 years ago

I think it would be fair with a little more explanation of a ~40k lines diff. E.g. is the role of data/uf_matrices.html and why is MAT.jl added as dependency?

KlausC commented 4 years ago

Sorry, the last 2 commits should not go there. They belong to the current WIP-PR and will be explained. For the moment, please ignore this until I have undone the unwanted commits.

KlausC commented 4 years ago

This PR is retired - I could not mange to revert the necessary commits. Added bug fix will be included in upcoming PR.