search

JuliaLinearAlgebra / MatrixDepot.jl

An Extensible Test Matrix Collection for Julia
http://matrixdepotjl.readthedocs.org/
Other
75 stars 22 forks source link

Avoid workflows which write to the project directory #75

Closed willow-ahrens closed 3 years ago

willow-ahrens commented 3 years ago

This branch intends to avoid workflows that write to the MatrixDepot.jl project directory. There are two parts of MatrixDepot which have this behavior: The default data directory and the custom matrix generator directory. So far, I have only replaced the default data directory with a directory managed by Scratch.jl (#73). Soon, I will make a PR to this branch that replaces the custom matrix generators with a simpler package-based solution. This branch supersedes #74 and is intended to be merged at some point in the future when the MatrixDepot developers feel comfortable requiring Julia 1.5.

codecov[bot] commented 3 years ago

Codecov Report

Merging #75 (4698ba6) into master (35545d1) will increase coverage by 0.16%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #75      +/-   ##
==========================================
+ Coverage   65.63%   65.79%   +0.16%     
==========================================
  Files          14       14              
  Lines        2348     2342       -6     
==========================================
  Hits         1541     1541              
+ Misses        807      801       -6
Impacted Files Coverage Δ
src/MatrixDepot.jl 96.15% <ø> (ø)
src/data.jl 78.57% <ø> (-7.15%) :arrow_down:
src/types.jl 45.08% <0.00%> (-2.95%) :arrow_down:
src/regu.jl 91.21% <0.00%> (+0.56%) :arrow_up:
src/downloadmm.jl 53.70% <0.00%> (+0.92%) :arrow_up:
src/download.jl 89.69% <0.00%> (+2.51%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 35545d1...4698ba6. Read the comment docs.

willow-ahrens commented 3 years ago

My proposed changes to replace custom code loading with a package-based solution are now ready for review in https://github.com/peterahrens/MatrixDepot.jl/pull/1.

andreasnoack commented 3 years ago

I think we should go ahead with this change. This shouldn't be a problem for anybody who is on an older version of Julia. If an important bugfix appears at some point then we can branch off from a commit before this one and backport the bugfix and make a bugfix release without these changes.

willow-ahrens commented 3 years ago

Shall I also merge in the proposed change in peterahrens#1 ?

andreasnoack commented 3 years ago

I'm in favor. It seems like the right solution to me. We should hear if @KlausC has any comments.