search

JuliaLinearAlgebra / MatrixDepot.jl

An Extensible Test Matrix Collection for Julia
http://matrixdepotjl.readthedocs.org/
Other
75 stars 22 forks source link

Don't print logging info with println #78

Closed andreasnoack closed 3 years ago

andreasnoack commented 3 years ago

Instead, use the info and warn macros. This is generally a better approach and allows for easier filtering/disabling of warning messages if needed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #78 (fe65e30) into master (1b6241b) will increase coverage by 0.01%. The diff coverage is 94.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
+ Coverage   65.74%   65.75%   +0.01%     
==========================================
  Files          14       14              
  Lines        2341     2342       +1     
==========================================
+ Hits         1539     1540       +1     
  Misses        802      802
Impacted Files Coverage Δ
src/download.jl 89.17% <88.88%> (+0.05%) :arrow_up:
src/MatrixDepot.jl 96.15% <100.00%> (ø)
src/downloadmm.jl 53.70% <100.00%> (ø)
src/downloadsp.jl 87.87% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b6241b...fe65e30. Read the comment docs.