JuliaLinearAlgebra / NonNegLeastSquares.jl

Some nonnegative least squares solvers in Julia
MIT License
46 stars 11 forks source link

can't "add" to julia 1.0.1 #12

Closed JeffFessler closed 3 years ago

JeffFessler commented 6 years ago

in 1.0.1 ]add NonNegLeastSquares

produces errors:

Resolving package versions...
ERROR: Unsatisfiable requirements detected for package NonNegLeastSquares [b7351bd1]:
 NonNegLeastSquares [b7351bd1] log:
 ├─possible versions are: [0.0.1, 0.1.0] or uninstalled
 ├─restricted to versions * by an explicit requirement, leaving only versions [0.0.1, 0.1.0]
 └─restricted by julia compatibility requirements to versions: uninstalled — no versions left

it installs fine in 0.7 though.

lstagner commented 6 years ago

The changes to make the package work for v0.7/v1.0 have not been tagged and released. You can add manually by doing pkg> add https://github.com/ahwillia/NonNegLeastSquares.jl

Cody-G commented 5 years ago

The changes to make the package work for v0.7/v1.0 have not been tagged and released.

When might the changes be tagged and released? We're thinking of making this package a dependency of a larger project. Thanks!

JeffFessler commented 5 years ago

I found an adequate solution in the Optim package.

lstagner commented 5 years ago

I have been keeping the package up to date with Julia and everything works fine. It just needs to be added to the registry

JeffFessler commented 5 years ago

apologies

MatFi commented 3 years ago

Any estimate on when the new version will make it to the registry?

JeffFessler commented 3 years ago

Seems like not much activity in this repo :( There are other NNLS methods available, e.g.: https://github.com/StevenWhitaker/NNLS.jl

MatFi commented 3 years ago

but also not in the registry.. :(

ahwillia commented 3 years ago

I'm happy to give anyone access to this repo to maintain it in the registry. I tried to move it over to the Julia optimizers community but that fell through for some reason

On Mon, Mar 22, 2021, 8:23 AM MatFi @.***> wrote:

but also not in the registry.. :(

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ahwillia/NonNegLeastSquares.jl/issues/12#issuecomment-804148399, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAE3NUM7O34AIK7ESJAALR3TE5OGXANCNFSM4FZCL5ZA .

JeffFessler commented 3 years ago

I am wiling to help with that. I would also like to add code coverage and a badge for that.

MatFi commented 3 years ago

That would be great. The [compat] section in the project.toml needs to be updated, but that should be straightforward and I could do that, but I've never registred a Package before, so I'm not sure if I'll be a help in that process.

ahwillia commented 3 years ago

You both should have push access now

JeffFessler commented 3 years ago

thanks for adding push access. i was able to push, but it seems like my attempts to trigger registration are not starting the registration process. i'm unsure if this is a permission issue or if something is wrong with the bot. i see registrations in the last hour https://github.com/JuliaRegistries/General so i suspect it is not the bot. @ahwillia can you look at #24 and repeat that same line as another request and see if you can kick start it? @MatFi the [compat] looked ok to me (because it seems to depend only on built-in packages i think) but if you see a needed change then submit a PR.

JeffFessler commented 3 years ago

well, my PR didn't seem to trigger code coverage so i've copied a github action from here: https://github.com/simonster/Reexport.jl/blob/master/.github/workflows/CI.yml and i hope that might do it. anyway it might be better to migrate to github actions from travis soon.

JeffFessler commented 3 years ago

solved by #23 and related work.