search

JuliaLinearAlgebra / NonNegLeastSquares.jl

Some nonnegative least squares solvers in Julia
MIT License
46 stars 11 forks source link

Project.toml, tests, and travis updates #20

Closed lstagner closed 4 years ago

lstagner commented 4 years ago

This supersedes PR #19

lstagner commented 4 years ago

@ahwillia if you install the Registrator.jl and the TagBot applications we can easily register the package

lstagner commented 4 years ago

hmm...the sparse array tests fail on julia 1.0-1.1 but pass for julia 1.2-1.3 and I don't know why. Should we set the minimum julia version to 1.2?

lstagner commented 4 years ago

Ok I just added a version check to make the sparse tests pass. It shouldn't affect performance since the compiler should optimize out the if statement.

ahwillia commented 4 years ago

Thanks for this @lstagner. I have not been staying up to date with advances in Julia -- would you like me to give you push access to this repository so that you can help me keep things current?

cc @degleris1

lstagner commented 4 years ago

That would work though you may to install the apps I mentioned. An alternative is to put repo up for adoption. The JuliaNLSolvers Organization might be a good fit.

ahwillia commented 4 years ago

@pkofod -- what do you think of migrating this repo into JuliaNLSolvers so that you all can keep it up to date?

pkofod commented 4 years ago

@pkofod -- what do you think of migrating this repo into JuliaNLSolvers so that you all can keep it up to date?

If I say no, will you come back and play with us? :)

lstagner commented 4 years ago

@pkofod are you willing to do it? If not @ahwillia can you give me write access so I can merge this branch.

pkofod commented 4 years ago

Yes, it's fine. As long as everyone is fine with me caring about design decisions, releases, etc .

ahwillia commented 4 years ago

Thanks @pkofod -- that all sounds good to me! What is the cleanest way to migrate it over?

@lstagner -- I'll give you write access right now just in case you need it for a short-term solution.

lstagner commented 4 years ago

Thanks. I will hold off trying to update the registry since I don't know how the ownership change will change things.

pkofod commented 4 years ago

Thanks @pkofod -- that all sounds good to me! What is the cleanest way to migrate it over?

You can transfer it to JuliaNLSolvers (or me) in the settings tabs I think.

ahwillia commented 4 years ago

Done -- I tried to transfer to JuliaNLSolvers but didn't have permission, so I just requested a transfer to you @pkofod

nignatiadis commented 3 years ago

Minor bump :D. Is there any chance the transfer and registration of this package could still happen? It would be convenient as I would like to register a package that depends on this.

ahwillia commented 3 years ago

Looks like @pkofod still has to accept the transfer.

nignatiadis commented 3 years ago

Thanks @ahwillia! I will probably hard-include the code in my package until this is resolved.

@pkofod let me know if I can do anything to help with the move!

ghost commented 3 years ago

Hi @nignatiadis. Just an FYI the registration of this package has been completed.

nignatiadis commented 3 years ago

That is great! Thank you for letting me know @tsano430!

JeffFessler commented 3 years ago

@pkofod it still seems sensible to house this under JuliaNLSolvers. https://github.com/JuliaNLSolvers What still needs to be done to make that happen?