search

JuliaLinearAlgebra / NonNegLeastSquares.jl

Some nonnegative least squares solvers in Julia
MIT License
46 stars 11 forks source link

option to initialize passive set P #28

Closed JeffFessler closed 3 years ago

JeffFessler commented 3 years ago

addresses #17

codecov[bot] commented 3 years ago

Codecov Report

Merging #28 (30a4337) into master (fed55e1) will decrease coverage by 0.06%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #28      +/-   ##
==========================================
- Coverage   89.87%   89.81%   -0.07%     
==========================================
  Files           9        8       -1     
  Lines         484      481       -3     
==========================================
- Hits          435      432       -3     
  Misses         49       49
Impacted Files Coverage Δ
src/interface.jl 79.16% <50.00%> (ø)
src/pivot_comb.jl 97.05% <100.00%> (-0.17%) :arrow_down:
src/NonNegLeastSquares.jl

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fed55e1...30a4337. Read the comment docs.

JeffFessler commented 3 years ago

@lstagner, github recommended you for a code review. you want to take a look or should i just proceed?

JeffFessler commented 3 years ago

@MatFi, I added a little test for P! and it works. See if you think it's ready now?