search

JuliaLinearAlgebra / NonNegLeastSquares.jl

Some nonnegative least squares solvers in Julia
MIT License
46 stars 11 forks source link

Block principal pivoting method is missing step 5 from Algorithm 2 of Kim & Park (2011) #9

Closed brossetti closed 6 years ago

brossetti commented 6 years ago

pivot_comb() can crash with a BoundsError because step 5 from Algorithm 2 of Kim & Park (2011) is missing. This can be resolved by adding a check between lines 55 and 56 that skips any iteration where nV == 0. I'm happy to submit a pull request if this project is still active.

ahwillia commented 6 years ago

Thanks! Happy to review and merge this. Nothing is in active development, but I will keep this going as a basic resource.

On Thu, Apr 19, 2018, 2:26 PM brossetti notifications@github.com wrote:

pivot_comb() can crash with a BoundsError because step 5 from Algorithm 2 of Kim & Park (2011) is missing. This can be resolved by adding a check between lines 55 and 56 https://github.com/ahwillia/NonNegLeastSquares.jl/blob/acbb191ca2d0b06d6f042512393b00df5d53a1a0/src/pivot_comb.jl#L55-L56 that skips any iteration where nV == 0. I'm happy to submit a pull request if this project is still active.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ahwillia/NonNegLeastSquares.jl/issues/9, or mute the thread https://github.com/notifications/unsubscribe-auth/AAm20ezaH4_XaEp804QH7P7ApMuqVFKIks5tqQETgaJpZM4Tchsg .